On 24 April 2017 at 22:25, Stefano Stabellini <sstabell...@kernel.org> wrote: > diff --git a/hw/9pfs/xen-9pfs.h b/hw/9pfs/xen-9pfs.h > new file mode 100644 > index 0000000..18f0ec0 > --- /dev/null > +++ b/hw/9pfs/xen-9pfs.h > @@ -0,0 +1,14 @@ > +/* > + * Xen 9p backend > + * > + * Copyright Aporeto 2017 > + * > + * Authors: > + * Stefano Stabellini <stef...@aporeto.com> > + * > + */
Trivial file, but I prefer it if we have a brief license statement in every file, just to be clear (it might accumulate more code later). > + > +#include <xen/io/protocols.h> > +#include "hw/xen/io/ring.h" > + > +DEFINE_XEN_FLEX_RING_AND_INTF(xen_9pfs); Is it worth a comment to dissuade people from thinking they can inline the file back into xen-9p-backend.c ? thanks -- PMM
