On 04/24/2017 03:49 PM, Peter Maydell wrote: > On 24 April 2017 at 06:15, Jason Wang <jasow...@redhat.com> wrote: >> The following changes since commit 32c7e0ab755745e961f1772e95cac381cc68769d: >> >> Merge remote-tracking branch >> 'remotes/juanquintela/tags/migration/20170421' into staging (2017-04-21 >> 15:59:27 +0100) >> >> are available in the git repository at: >> >> https://github.com/jasowang/qemu.git tags/net-pull-request >> >> for you to fetch changes up to 049f6d8237dd0b14dee02e4c22b20114c43cecff: >> >> COLO-compare: Optimize tcp compare trace event (2017-04-24 11:30:36 +0800) >> >> ---------------------------------------------------------------- >> >> ---------------------------------------------------------------- > > Hi. Clang picks up what looks like a typo: > > /Users/pm215/src/qemu-for-merges/hw/net/ftgmac100.c:809:33: error: use > of logical '&&' with constant operand > [-Werror,-Wconstant-logical-operand] > if (size < 64 && !(s->maccr && FTGMAC100_MACCR_RX_RUNT)) { > ^ ~~~~~~~~~~~~~~~~~~~~~~~ > /Users/pm215/src/qemu-for-merges/hw/net/ftgmac100.c:809:33: note: use > '&' for a bitwise operation > if (size < 64 && !(s->maccr && FTGMAC100_MACCR_RX_RUNT)) { > ^~ > & > /Users/pm215/src/qemu-for-merges/hw/net/ftgmac100.c:809:33: note: > remove constant to silence this warning > if (size < 64 && !(s->maccr && FTGMAC100_MACCR_RX_RUNT)) { > ~^~~~~~~~~~~~~~~~~~~~~~~~~~
Jason, How do you want to handle that ? A resend of the patch or a fix ? Thanks, C.
