On 04/19/2017 09:42 AM, Paolo Bonzini wrote:
> !job is always checked prior to the call, drop it from here.
>
> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
> blockjob.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockjob.c b/blockjob.c
> index 6e48932..23022b3 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -480,7 +480,7 @@ static bool block_job_should_pause(BlockJob *job)
>
> bool block_job_user_paused(BlockJob *job)
> {Is it worth using some form of attribute((nonnull)) annotations on various functions, to both state our intentions and let compilers help us catch obvious places where we are violating our intentions? That's more of a generic question to all of qemu, and doesn't affect your particular patch, other than your patch is an instance where the annotation would be useful if we wanted to use them. > - return job ? job->user_paused : 0; > + return job->user_paused; > } > > void coroutine_fn block_job_pause_point(BlockJob *job) > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
