On 04/18/2017 12:31 PM, Jeff Cody wrote: > For the tests that use the common.qemu functions for running a QEMU > process, _cleanup_qemu must be called in the exit function. > > If it is not, if the qemu process aborts, then not all of the droppings > are cleaned up (e.g. pidfile, fifos). > > This updates those tests that did not have a cleanup in qemu-iotests. > > (I swapped spaces for tabs in test 102 as well) > > Reported-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Jeff Cody <jc...@redhat.com> > ---
> +++ b/tests/qemu-iotests/094
> @@ -27,7 +27,14 @@ echo "QA output created by $seq"
> here="$PWD"
> status=1 # failure is the default!
>
> -trap "exit \$status" 0 1 2 3 15
> +_cleanup()
> +{
> + _cleanup_qemu
> + _cleanup_test_img
> + rm -f "$TEST_DIR/source.$IMGFMT"
> +}
> +
> +trap "cleanup; exit \$status" 0 1 2 3 15
s/cleanup/_cleanup/
Once you fix that typo,
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
