On Tue, Apr 18, 2017 at 04:43:48PM +0300, Marcel Apfelbaum wrote: > On 04/18/2017 12:59 AM, Eduardo Habkost wrote: > > Every single caller of of pci_register_bus() saves the return value in > > phb->bus. Do that inside pci_register_bus() to avoid code duplication > > and make it harder to break. > > > > I personally find that more difficult to follow, maybe the function > name is misleading. > Maybe we can find a better function name or explain the side effect > in a comment?
I agree we need better function names (for both pci_register_bus() and pci_bus_new*()). But I am not experienced enough with the PCI code to find a good name. Any suggestions? -- Eduardo
