Haozhong Zhang <haozhong.zh...@intel.com> writes: > Add an optional argument 'devtype' to 'query-memory-devices', which > is either 'dimm' or 'nvdimm'. If 'devtype' is missed or 'dimm', all > memory devices will be listed. If 'devtype' is 'nvdimm', only nvdimm > devices will be listed.
Basically, the argument provides limited server-side filtering of the output of query-memory-devices. > Signed-off-by: Haozhong Zhang <haozhong.zh...@intel.com> > --- > Cc: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > Cc: Xiao Guangrong <guangrong.x...@linux.intel.com> > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Igor Mammedov <imamm...@redhat.com> > Cc: Eric Blake <ebl...@redhat.com> > Cc: Markus Armbruster <arm...@redhat.com> > --- > hmp.c | 3 +- > hw/mem/nvdimm.c | 38 ++++++++++++++++++++++++++ > hw/mem/pc-dimm.c | 71 > ++++++++++++++++++++++++++++-------------------- > include/hw/mem/nvdimm.h | 2 ++ > include/hw/mem/pc-dimm.h | 1 + > qapi-schema.json | 48 +++++++++++++++++++++++++++++--- > qmp.c | 13 +++++++-- > 7 files changed, 140 insertions(+), 36 deletions(-) Why is this server-side filtering worth the additional code and complexity? Why not simply filter in the client? What's your use case? [...]
