Hi Omar, > From: Omar Rizwan [mailto:omar.riz...@gmail.com] > Sent: Friday, 7 April 2017 22:43
Did you do any testing of this? One of the reasons I never got around to upstreaming this was that I couldn't get Raspbian working reliably (there was some problem with stalled DMA reads from the MMC controller), and I didn't have the cycles to debug it further. Also, IIRC Raspbian on pi1 depended on the system timer devices, so it might not make sense to have this board-level support without adding that first. > --- a/hw/arm/bcm2835_peripherals.c > +++ b/hw/arm/bcm2835_peripherals.c > @@ -34,6 +34,7 @@ static void bcm2835_peripherals_init(Object *obj) > /* Internal memory region for peripheral bus addresses (not exported) */ > memory_region_init(&s->gpu_bus_mr, obj, "bcm2835-gpu", (uint64_t)1 << > 32); > object_property_add_child(obj, "gpu-bus", OBJECT(&s->gpu_bus_mr), > NULL); > + sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->gpu_bus_mr); > > /* Internal memory region for request/response communication with > * mailbox-addressable peripherals (not exported) This line looks like it might have snuck in by accident? Andrew
