On 04/06/2017 10:10 AM, Sahid Orentino Ferdjaoui wrote: > On Wed, Apr 05, 2017 at 04:21:29PM -0700, Anthony Xu wrote: >> move xen-common.c to hw/xen/ >> >> Signed-off -by: Anthony Xu <anthony...@intel.com> > > nit: s/Signed-off -by/Signed-off-by, not sure if it's really important > or not.
Some of the automated tooling may choke on the misspelled variant, and S-o-b is legally important, so it is worth fixing. By the way, you can use 'git commit -s' or 'git send-email -s' to add S-o-b in the proper format at a given stage in your workflow, rather than having to type it by hand; it becomes obvious that you didn't use git's automation for adding it when you have a typo or when you have more than one blank line between your S-o-b and the --- separator. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
