On 04/06/2017 11:16 AM, Benjamin Herrenschmidt wrote: > On Thu, 2017-04-06 at 11:06 +0200, Cédric Le Goater wrote: >> The object will be initialized which raises some concern because we don't >> have the chip id at the moment but the object is still valid in some way. >> I think I need to remove it from the list of children of the chip or use >> a pointer instead. > > Well... so it exists on all chips. All chips have an LPC controller... > > Whether firmware enables it and whether it's connected to anything is a > system issue.
So, looking at hostboot, the lower level firmware, I think the initial patch is more in sync with it : https://github.com/open-power/hostboot/blob/master-p8/src/usr/devtree/bld_devtree.C#L1038 David, can we keep it as it is ? I will change the commit log which is a bit fuzzy. Cheers, C.
