On Mon, 18 Oct 2010 11:36:55 +0530 Prerna Saxena <pre...@linux.vnet.ibm.com> wrote:
> This patch set introduces two QMP interfaces for tracing : > > * query-trace : to list current contents of trace-buffer > * query-trace-events : to list all available trace-events with their state. This is in my to-review queue, but it's going to take a few days, because I have to take a deeper look at the tracing feature to be able to review it. Two initial questions: o This is labeled as an RFC, but you're versioning it. Should this be considered for inclusion? o Is this really useful w/o being able to set new traces? > > Changelog : > ----------- > Changes v2 -> v3 : > - Change declarations of st_print_trace_to_qlist() and > st_print_trace_events_to_qlist() to return QList* > > Changes v1 -> v2 : > - Add 'timestamp' field for query-trace output. > - Misc cleanups. >