On 28 March 2017 at 00:35, Richard Henderson <r...@twiddle.net> wrote: > On 03/28/2017 02:04 AM, Peter Maydell wrote: >> >> These patches fix problems with the SPARC TCG backend code >> which calls the load and store helpers. Where the argument >> being passed to the helper is narrower than the size of the >> native register, the SPARC calling convention requires that >> we extend it to the register size, but we weren't doing that. >> This meant we passed the host code registers which might have >> garbage in the high parts, and if the host code was built >> with optimization this resulted in wrong behaviour. >> >> I still see problems trying to run the bits of 'make check' >> that run guest code, but at least with these patches we can >> run the i386 bios code enough to try to do PXE boot and not >> find a server. >> >> >> Peter Maydell (2): >> tcg/sparc: Zero extend data argument to store helpers >> tcg/sparc: Zero extend address argument to ld/st helpers >> >> tcg/sparc/tcg-target.inc.c | 31 +++++++++++++++++++++++++++++-- >> 1 file changed, 29 insertions(+), 2 deletions(-) >> > > Reviewed-by: Richard Henderson <r...@twiddle.net>
Applied to master, thanks. (PS: your mail system seems to have sat on your reviewed-by email for the best part of a week.) thanks -- PMM