On 03/31/2017 07:36 AM, Peter Maydell wrote: > Occasionally if a test crashes or is interrupted by the user > at the wrong moment it could leave behind a stale UNIX > socket in /tmp/. This will then cause a subsequent test > run to fail spuriously with > tests/libqtest.c:70:init_socket: assertion failed (ret != -1): (-1 != -1) > if it happens to reuse the same PID. > > Defend against this by deleting any stray stale socket before > trying to open the new ones for this test. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > This seems like an easy way to shut up this infrequent but irritating > error case...
There is a related failure in qemu-iotests that I hit yesterday: +mkfifo: cannot create fifo '/home/eblake/qemu/tests/qemu-iotests/scratch/qmp-out-3812_0': File exists that is probably also worth addressing, but that can be a separate patch. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature