On 31 March 2017 at 14:51, Peter Maydell <peter.mayd...@linaro.org> wrote: > In commit e330c118f2a5a the last usage of main_loop_wait() that cared > about the return value was changed to no longer use it. Drop the > now-useless return value and make the function return void. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > Coverity complains (CID 1372464) about main_loop() calling > main_loop_wait() and ignoring its return value. I suspect > this change will just displace that to within main_loop_wait() > itself since the underlying issue there is "the ppoll() that > gets called to poll fds can return an error code, but what > do we do if it does?". Suggestions on that point welcome. > > I guess this will make the compiler warn about ret being > set and never used if CONFIG_SLIRP is not defined, which > is irritating. I'm postponing messing about with fixing > that in favour of seeing whether anybody has a good answer > to the question above (which might make it moot). > ---
...oops, I meant to tag this RFC; never mind. thanks -- PMM
