On 03/30/2017 12:14 PM, Ed Maste wrote:
On 30 March 2017 at 12:12, Corey Minyard <tcminy...@gmail.com> wrote:
This isn't quite right, a lot of these need parenthesis around the whole
thing, and some of the macros are unused and need to be removed.
I had submitted something for this a while ago, but it hadn't been
taken. I will re-submit.
Ok, thanks and apologies for not noticing existing patch and discussion.
Not a problem, I had forgotten about this and it spurred me to action.
On the topic of building with recent Clang there are also a large
number of warnings of the form "taking the address of a packed member
'magic' of class or structure 'QCowHeader' may result in an unaligned
pointer value [-Waddress-of-packed-member]". Unfortunately this
warning seems to be overly aggressive and prone to false positives.
You should probably bring this up in a new thread.
-corey
