On 03/25/2017 06:12 AM, Alex Williamson wrote: > On Thu, 23 Mar 2017 17:09:22 +0800 > Cao jin <caoj.f...@cn.fujitsu.com> wrote: > > This is not a sufficiently trivial patch to leave the commit log empty. > >> Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> >> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> >> ---
>> + pcie_cap_deverr_init(pdev); > > This assumes we've set exp_cap, perhaps the code should validate this > to avoid corner case configurations where the PCIe cap has been dropped > yet AER is still present. I'm not sure if it's possible, but I'd > rather test than segfault. > >> + return pcie_aer_init(pdev, cap_ver, pos, size, errp); > > > I think here too, users may have existing configurations that could > break by suddenly imposing a new topology requirement. > Not quite follow, test what for pcie_aer_init()? -- Sincerely, Cao jin
