On 03/16/2017 03:38 AM, He Chen wrote: > Current, QEMU does not provide a clear command to set vNUMA distance for > guest although we already have `-numa` command to set vNUMA nodes.
Subject line: "Allow to $verb" is not idiomatic English. It is either
"Allow $subject to $verb", or the shorter "Allow ${verb}ing"; in this
case, I'd go with "Allow setting NUMA distance...".
> +++ b/qapi-schema.json
> @@ -5647,7 +5647,7 @@
> # Since: 2.1
> ##
> { 'enum': 'NumaOptionsType',
> - 'data': [ 'node' ] }
> + 'data': [ 'node', 'dist' ] }
Missing documentation for dist.
>
> ##
> +# @NumaDistOptions:
> +#
> +# Set distance between 2 NUMA nodes. (for OptsVisitor)
The '(for OptsVisitor)' comment doesn't add anything useful; I'd drop it.
>
> +@var{source} and @var{destination} are NUMA node ID.
Maybe s/ID/IDs/
> +@var{distance} is NUMA distance from @var{source} to @var{destination}.
s/is/is the/
> +The distance from node A to node B may be different from the distance from
> +node B to node A since the distance allows to be asymmetry.
s/allows to be asymmetry/can be asymmetric/
> +If the distance is not set, the default distance for local NUMA node is 10,
> +and 20 for remote node.
s/for/for a/g
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
