On Sat, Mar 18, 2017 at 12:51:29AM +0000, Nir Soffer wrote: > On Wed, Mar 15, 2017 at 11:29 AM Stefan Hajnoczi <stefa...@redhat.com> > wrote: > > diff --git a/block.c b/block.c > > index cb57370..532a4d1 100644 > > --- a/block.c > > +++ b/block.c > > @@ -3260,6 +3260,39 @@ int64_t > > bdrv_get_allocated_file_size(BlockDriverState *bs) > > return -ENOTSUP; > > } > > > > +/* > > + * bdrv_measure: > > + * @drv: Format driver > > + * @opts: Creation options > > > > Isn't this Measure options?
No, these are the block driver .bdrv_create() options. They are exactly the same as qemu-img create -o. qemu-img measure must know the creation options of the new image file (such as preallocation or the qcow2 image format version) because they affect the file size. > Maybe a note about error handling? the only way is to check for non-null > errp, right? Yes, errp must be checked. I'll update the doc comment.
signature.asc
Description: PGP signature
