On 17 March 2017 at 17:52, Stefan Weil <s...@weilnetz.de> wrote: > Am 17.03.2017 um 17:08 schrieb Paolo Bonzini: >> >> The Cygwin target is really compiling for native Win32 with -mno-cygwin. >> Except, GCC 4.7.0 has finally removed the long deprecated -mno-cygwin >> option, and that happened about five years ago. >> >> Let it rest in peace. >> >> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> >> --- > > > Reviewed-by: Stefan Weil <s...@weilnetz.de> > > CC'ing qemu-trivial for the pull request. > > I only wonder whether we should raise an error if people > try building QEMU with native Cygwin (not Cygwin / Mingw-w64).
I think the "warn about deprecated hosts" patch that I posted earlier today will effectively end up doing that, because it changes the case $targetos from "default to assuming Linux" to "explicitly check for Linux, and default to an error message". thanks -- PMM
