On Mon, Oct 11, 2010 at 12:52 PM, Markus Armbruster <arm...@redhat.com> wrote:
> Warns about this line in check-qjson.c:
>    QObject *obj = qobject_from_json("");
>
> The obvious fix (add -Wno-format-zero-length to gcc_flags) doesn't
> work, because -Wall switches it on again.  Fix by putting configured
> flags last.

This would disable the flag globally. I'd rather disable the flag only
for check-qjson.o or more generically, remove -Werror for checks. For
example, there could be a check for how we handle invalid formats and
then the sources would contain format strings that annoy GCC, but we
wouldn't want warnings from that to stop the build.

Reply via email to