On 03/13/2017 01:18 AM, Markus Armbruster wrote: > At the protocol level, the distinction between struct, flat union and > simple union is meaningless, they are all JSON objects. Document them > that way. > > Example change (qemu-qmp-ref.txt): > > - -- Simple Union: InputEvent > + -- Object: InputEvent > > Input event union.
Yay - and even addresses one of my comments earlier in the series about
a needless distinction between simple and flat unions.
>
> This also fixes the completely broken headings for flat and simple
> unions in qemu-qmp-ref.7 and qemu-ga-ref.7, by sidestepping a bug in
> texi2pod.pl. For instance, it mistranslates "@deftp {Simple Union}
> InputEvent" to "B<Union> (Simple)", but translates "@deftp Object
> InputEvent" to "B<SocketAddress> (Object)".
>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
> scripts/qapi2texi.py | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
