On Tue, Mar 14, 2017 at 11:26:19AM +0100, Paolo Bonzini wrote: > > > On 13/03/2017 04:02, Peter Xu wrote: > > On Sun, Mar 12, 2017 at 09:12:43PM +0200, Michael S. Tsirkin wrote: > >> info mtree is doing 64 bit math to figure out > >> addresses from offsets, this does not work ncorrectly > >> incase of overflow. > >> > >> Overflow usually indicates a guest bug, so this is unusual > >> but reporting correct addresses makes it easier to discover > >> what is going on. > > > > A tiny issue would be that we will always dump 128 bits even if > > nothing went wrong. IMHO That's slightly awkward. Not sure whether > > that will confuse people since they should be thinking why we need > > that on 64bit systems... > > > > Do you like below one instead? It'll keep the old interface, but just > > warn user explicity when something wrong happens, and it's much easier > > and obvious imho (along with a tiny cleanup): > > > > (the code is not tested even for compile) > > Looks good, can you submit it formally?
Sure! Will do. -- peterx
