On Mon, Mar 13, 2017 at 03:01:04PM +0530, Nikunj A Dadhania wrote: > A bug was introduced in following commit: > > dc0ad84 target/ppc: update overflow flags for add/sub > > As for 32-bit ppc target extracting bit 63 for overflow is not correct. > Made it dependent on TARGET_LOG_BITS. This had broken booting MacOS > 9.2.1 image > > Reported-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > Signed-off-by: Nikunj A Dadhania <nik...@linux.vnet.ibm.com>
Applied to ppc-for-2.9, thanks.
> ---
> target/ppc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index b6abc60..f40b5a1 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -818,7 +818,7 @@ static inline void gen_op_arith_compute_ov(DisasContext
> *ctx, TCGv arg0,
> if (is_isa300(ctx)) {
> tcg_gen_extract_tl(cpu_ov32, cpu_ov, 31, 1);
> }
> - tcg_gen_extract_tl(cpu_ov, cpu_ov, 63, 1);
> + tcg_gen_extract_tl(cpu_ov, cpu_ov, TARGET_LONG_BITS - 1, 1);
> }
> tcg_gen_or_tl(cpu_so, cpu_so, cpu_ov);
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
