On 03/13/2017 11:59 AM, Julian Kirsch wrote: > Provide read/write access to x86 model specific registers (MSRs) by means of > two new HMP commands "msr-get" and "msr-set". The rationale behind this > is to improve introspection capabilities for system virtualization mode. > For instance, many modern x86-64 operating systems maintain access to internal > data structures via the MSR_GSBASE/MSR_KERNELGSBASE MSRs. Giving > introspection utilities (such as a remotely attached gdb) a way of > accessing these registers improves analysis results drastically. > > Changes v1 -> v2: > * Rename HMP commands to "msr-get" and "msr-set"
Most HMP commands still use '_'; it is only QMP where we insist on '-' in new interfaces. (And yes, there's not much rhyme or reason to that other than backwards consistency.) > * HMP commands Operate on the current default CPU only > (removes need for cpu_index argument) > * Remove QMP command alltogether > * Implement HMP command in target/i386/monitor.c > * Add #ifdef TARGET_I386 around msr-get/msr-set in hmp-commands.hx > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature