Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH] hw/arm/boot: take Linux/arm64 TEXT_OFFSET header
field into account
Message-id: 1489079383-11162-1-git-send-email-ard.biesheu...@linaro.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/1489079383-11162-1-git-send-email-ard.biesheu...@linaro.org ->
patchew/1489079383-11162-1-git-send-email-ard.biesheu...@linaro.org
- [tag update] patchew/20170309132216.23482-1-dgilb...@redhat.com ->
patchew/20170309132216.23482-1-dgilb...@redhat.com
Switched to a new branch 'test'
55ab14d hw/arm/boot: take Linux/arm64 TEXT_OFFSET header field into account
=== OUTPUT BEGIN ===
Checking PATCH 1/1: hw/arm/boot: take Linux/arm64 TEXT_OFFSET header field into
account...
ERROR: braces {} are necessary for all arms of this statement
#55: FILE: hw/arm/boot.c:791:
+ if (fd < 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#62: FILE: hw/arm/boot.c:798:
+ if (bytes < ARM64_IMAGE_HEADER_SIZE)
[...]
ERROR: braces {} are necessary for all arms of this statement
#67: FILE: hw/arm/boot.c:803:
+ if (memcmp(buffer + ARM64_MAGIC_OFFSET, "ARM\x64", 4) != 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#75: FILE: hw/arm/boot.c:811:
+ if (headerval == 0)
[...]
total: 4 errors, 0 warnings, 74 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
