On 03/09/2017 03:55 AM, QingFeng Hao wrote: > > > 在 2017/3/8 19:33, Halil Pasic 写道: >> >> On 03/08/2017 08:05 AM, QingFeng Hao wrote: >>> >>> 在 2017/3/7 18:19, Halil Pasic 写道: >>>> On 03/07/2017 11:05 AM, Kevin Wolf wrote: >>>>> Am 07.03.2017 um 10:54 hat Halil Pasic geschrieben: >>>>>> On 03/07/2017 10:29 AM, Kevin Wolf wrote: >>>>>>> Am 07.03.2017 um 03:53 hat QingFeng Hao geschrieben: [..] >>> The question is: can we do that change and what the second assert of >>> field's flags is used for? >> The assert is there to guard against unintended use of this nullptr-marker >> mechanism. >> >> I have tested so this should work. By the way a vmstate test covering this >> corner-case would be a good idea too (IMHO). Would you like to write one? > Sorry, I don't know how to write that test case. Can you please write one? > thanks!
The test is just nice to have, but we definitely need the fix! Halil