On Tue, Mar 07, 2017 at 09:44:02AM -0600, Eric Blake wrote: > On 02/22/2017 05:46 PM, Eric Blake wrote: > > On 02/21/2017 05:55 AM, Daniel P. Berrange wrote: > >> The previous commit: > >> > >> commit a3e1505daec31ef56f0489f8c8fff1b8e4ca92bd > >> Author: Eric Blake <ebl...@redhat.com> > >> Date: Mon Dec 5 09:49:34 2016 -0600 > >> > >> qcow2: Don't strand clusters near 2G intervals during commit > >> > >> extended the 097 test case so that it did two passes, once > >> with an internal snapshot, once without. > >> > >> qcow (v1) does not support internal snapshots, so this change > >> broke test 097 when run against qcow. > >> > >> This splits 097 in two, creating a new 173 that tests the > > 173 is wrong, and 175 is now taken. > > >> internal snapshot codepath, effectively putting 097 back > >> to its content before the above commit. > >> > >> Reviewed-by: Max Reitz <mre...@redhat.com> > >> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > >> --- > >> tests/qemu-iotests/097 | 10 +--- > >> tests/qemu-iotests/097.out | 125 > >> ++------------------------------------------ > >> tests/qemu-iotests/175 | 126 > >> +++++++++++++++++++++++++++++++++++++++++++++ > >> tests/qemu-iotests/175.out | 119 > >> ++++++++++++++++++++++++++++++++++++++++++ > > I'll be incorporating this patch into my series on blkdebug > improvements, as I have a further enhancement (to both 97 and what is > now 176) to cover an image that is not cluster-aligned. You may want to > rebase the rest of your series (which adds two more tests) on top of > that posting. > > > I used 175 in v5 of my blkdebug series, but Kevin had comments that are > > worth me respinning, so I'm rebasing mine to use 176. > > https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg03049.html > > Particularly since my blkdebug series will now be using 177.
/me can't help thinking that we should being giving tests names instead of numbers so we avoid the frequent clashes between people's series :-) Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
