Eric Blake <ebl...@redhat.com> writes: > On 03/05/2017 02:35 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> Reviewed-by: Eric Blake <ebl...@redhat.com> >> Message-Id: <1488544368-30622-4-git-send-email-arm...@redhat.com> >> --- >> MAINTAINERS | 1 + >> tests/Makefile.include | 5 +- >> tests/libqtest.c | 17 ++++-- >> tests/libqtest.h | 8 +++ >> tests/qmp-test.c | 139 >> +++++++++++++++++++++++++++++++++++++++++++++++++ >> 5 files changed, 164 insertions(+), 6 deletions(-) >> create mode 100644 tests/qmp-test.c > > Just now noticing (so a followup patch is fine, no need to stall the > pull request), but this should probably tweak .gitignore for the new > test
Covered by the *-test line there. Whether it's a good idea is a separate question. I don't really like such globs in .gitignore myself. In Makefiles even less. > (or maybe we should revive Marc-André's proposal to generate > .gitignore at make time). Maintaining .gitignore for generated files manually is tiresome, so automation would be nice, if we can pull it off -- writing into the source tree is a bit tricky to get right.
