Eric Blake <ebl...@redhat.com> writes:
> On 03/05/2017 02:01 AM, Markus Armbruster wrote:
>
>>>> @@ -41,15 +41,17 @@ static QDict *qmp_dispatch_check_obj(const QObject
>>>> *request, Error **errp)
>>>>
>>>> if (!strcmp(arg_name, "execute")) {
>>>> if (qobject_type(arg_obj) != QTYPE_QSTRING) {
>>>> - error_setg(errp, "QMP input object member '%s' expects
>>>> '%s'",
>>>> - "execute", "string");
>>>> + error_setg(errp,
>>>> + "QMP input object member '%s' must be %s",
>>>> + "execute", "a string");
>>>
>>> let's avoid formatting like the rest of this patch.
>>>
>
>> Since substantial other work depends on this series, it needs to go in
>> sooner rather than later. I'm therefore *dropping* this patch from the
>> series. We can then bikeshed^Wpolish to our heart's content without
>> holding up other work.
>
> Agreed.
>
>>
>> That said: what about this?
>
> Looks better. Do you want R-b now, or when you re-post it as an
> official patch?
I'll gladly take it either way :)
