From: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> Comparison symbol is misused. It may lead to memory corruption. Introduced in commit 7d3123e.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> Message-Id: <20170203154757.36140-6-vsement...@virtuozzo.com> [eblake: add CVE details] Signed-off-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Marc-André Lureau <address@hidden> --- This one still hasn't been merged in; sending separately since the rest of my NBD series is now 2.10 material: https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg04528.html nbd/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd/client.c b/nbd/client.c index 5c9dee3..165b33e 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -94,7 +94,7 @@ static ssize_t drop_sync(QIOChannel *ioc, size_t size) char small[1024]; char *buffer; - buffer = sizeof(small) < size ? small : g_malloc(MIN(65536, size)); + buffer = sizeof(small) > size ? small : g_malloc(MIN(65536, size)); while (size > 0) { ssize_t count = read_sync(ioc, buffer, MIN(65536, size)); -- 2.9.3
