On 03/04/2017 05:21 AM, Greg Kurz wrote: > On Fri, 3 Mar 2017 17:43:49 -0600 > Eric Blake <ebl...@redhat.com> wrote: >
> It is acceptable to ignore O_PATH here because we have O_DIRECTORY, and > we know openat_dir() will hence fail. But this code sits in a header > file, and we probably don't want O_PATH to be silently converted to 0 in > other potential cases where it is used without O_DIRECTORY. > > I'd rather do something like the following then: > > #ifdef O_PATH > #define OPENAT_DIR_O_PATH O_PATH > #else > #define OPENAT_DIR_O_PATH 0 > #endif > > Makes sense ? Yes, that's reasonable. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
