[adding qemu-trivial in cc] On 03/03/2017 01:18 PM, Suramya Shah wrote: > Signed-off-by: Suramya Shah <shah.sura...@gmail.com> > ---
It would have been nice to mention in the subject that this is v2 (v1 was here https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg00110.html), and then mention here after the --- that the difference was a fix of a typo that broke compilation. Also, the subject line doesn't follow the usual conventions of "topic: Description", a topic of 'util: ' may be appropriate. > util/path.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Eric Blake <ebl...@redhat.com> > diff --git a/util/path.c b/util/path.c > index 5479f76..7f9fc27 100644 > --- a/util/path.c > +++ b/util/path.c > @@ -6,7 +6,6 @@ > #include "qemu/osdep.h" > #include <sys/param.h> > #include <dirent.h> > -#include "qemu-common.h" > #include "qemu/cutils.h" > #include "qemu/path.h" > > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature