On 10 December 2016 at 02:05, BALATON Zoltan <bala...@eik.bme.hu> wrote: > This is to allow clients to initialise these without failing as long > as no 2D engine function is called that would use the written value. > Saved values are not used yet (may get used when more of 2D engine is > added sometimes) and clients normally only write to most of these > registers, nothing is known to ever read them but they are documented > as read/write so also implement read for these. > > Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu> > --- > > v2: Fixed mask of video_control register for a read only bit > Changed IRQ status register to write ignored as IRQ is not implemented > v3: Squashed read implementation into this patch > > hw/display/sm501.c | 107 > ++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 106 insertions(+), 1 deletion(-) >
> @@ -1454,6 +1558,7 @@ static void sm501_reset(SM501State *s) > s->misc_timing = 0; > s->power_mode_control = 0; > s->dc_panel_control = 0x00010000; /* FIFO level 3 */ > + s->dc_video_control = 0; > s->dc_crt_control = 0x00010000; > s->twoD_control = 0; > } You want to reset all these new fields, not just one of them. If you do that then you can add Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
