On Thu, 2 Mar 2017, Peter Maydell wrote:
On 25 February 2017 at 21:47, BALATON Zoltan <bala...@eik.bme.hu> wrote:
Clients normally only write to these registers, nothing is known to
ever read them but they are documented as read/write so allow clients
to also read the values.
Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu>
---
hw/display/sm501.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 57 insertions(+)
Oh, the read code is in a separate patch? Please put all the handling
for a particular register in the same patch. If you think the
resulting patch is too long you can split it into several patches
each of which handles a group of registers if you like (but it
probably isn't necessary).
So is it OK to squash this in the previous patch adding write and make the
two a single patch?
thanks
-- PMM
