On 03/02/2017 06:37 AM, Daniel P. Berrange wrote: > Currently the query-migrate-parameters command will omit reporting > of the tls-creds & tls-hostname parameters if their value is NULL. > This makes it impossible for an app to detect if these parameters > are supported by QEMU, without trying to actually set them and > catching the error. Since the code is treating "" and NULL as > equivalent, we can simply always report these values and give them > a value of "". This allows apps like libvirt to detect the fact > that these parameters are supported by QEMU. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > migration/migration.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-)
The .c changes look fine, but I agree that we want to document the special-case of "" in the .json file. Looking forward to v3. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
