On 02/28/2017 11:39 AM, Markus Armbruster wrote: > Fix the design flaw demonstrated in the previous commit: new method > check_list() lets input visitors report that unvisited input remains > for a list, exactly like check_struct() lets them report that > unvisited input remains for a struct or union. > > Implement the method for the qobject input visitor (straightforward), > and the string input visitor (less so, due to the magic list syntax > there). The opts visitor's list magic is even more impenetrable, and > all I can do there today is a stub with a FIXME comment. No worse > than before. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > ---
> +++ b/hw/ppc/spapr_drc.c
> @@ -326,7 +326,12 @@ static void prop_get_fdt(Object *obj, Visitor *v, const
> char *name,
> return;
> }
> }
> + visit_check_list(v, &err);
> visit_end_list(v, NULL);
> + if (err) {
> + error_propagate(errp, err);
> + return;
> + }
> break;
> }
Better. Thanks for the fast respin.
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
