On 02/22/2017 07:31 PM, Markus Armbruster wrote: > Marek Vasut <ma...@denx.de> writes: > >> On 02/22/2017 07:31 AM, Markus Armbruster wrote: >>> I know this has been committed already, but here goes anyway: >>> >>> Marek Vasut <ma...@denx.de> writes: >>> >>>> From: Chris Wulff <crwu...@gmail.com> >>>> >>>> Add the Altera Nios2 internal interrupt controller model. >>>> >>>> Signed-off-by: Marek Vasut <ma...@denx.de> >>>> Cc: Chris Wulff <crwu...@gmail.com> >>>> Cc: Jeff Da Silva <jdasi...@altera.com> >>>> Cc: Ley Foon Tan <lf...@altera.com> >>>> Cc: Sandra Loosemore <san...@codesourcery.com> >>>> Cc: Yves Vandervennet <yvand...@altera.com> >>>> Cc: Alexander Graf <ag...@suse.de> >>>> Cc: Richard Henderson <r...@twiddle.net> >>>> Reviewed-by: Alexander Graf <ag...@suse.de> >>>> --- >>>> V3: Checkpatch cleanup >>>> V4: Rebase on top of qemu/master >>>> V5: Rebase on top of qemu/master >>>> --- >>>> hw/intc/Makefile.objs | 1 + >>>> hw/intc/nios2_iic.c | 103 >>>> ++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> 2 files changed, 104 insertions(+) >>>> create mode 100644 hw/intc/nios2_iic.c >>>> >>>> diff --git a/hw/intc/Makefile.objs b/hw/intc/Makefile.objs >>>> index 2f44a2da26..8948106ac4 100644 >>>> --- a/hw/intc/Makefile.objs >>>> +++ b/hw/intc/Makefile.objs > [...] >>>> +static Property altera_iic_properties[] = { >>>> + DEFINE_PROP_PTR("cpu", AlteraIIC, cpu), >>> >>> Could this be a QOM link instead? >>> >>> We want to get rid of pointer properties. Commit d2fe4ec converts one >>> to a link. >> >> By all means, yes. Can you send a patch ? I can help testing it. >> Otherwise I can cook one up, but it might take a few days. > > I'm in a bit of a time squeeze right now, and I'd be grateful if you > could do it. A few days sounds great to me.
Heh, tell me about this time squeeze ... -- Best regards, Marek Vasut