On 02/23/2017 03:31 AM, David Gibson wrote:
> On Thu, Feb 16, 2017 at 02:47:32PM +0100, Cédric Le Goater wrote:
>> It is not used anymore now that we have the QOM interface for XICS.
>>
>> Signed-off-by: Cédric Le Goater <c...@kaod.org>
>
> Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
>
> Several of these patches are small enough that I wonder if they could
> be merged, though.
yes I could probably keep all the removal at the end. I will take
a look at that.
Thanks,
C.
>
>> ---
>> hw/intc/xics.c | 12 ------------
>> include/hw/ppc/xics.h | 1 -
>> 2 files changed, 13 deletions(-)
>>
>> diff --git a/hw/intc/xics.c b/hw/intc/xics.c
>> index 2decb921e4e3..bfd3a539561a 100644
>> --- a/hw/intc/xics.c
>> +++ b/hw/intc/xics.c
>> @@ -737,18 +737,6 @@ static const TypeInfo xics_interface_info = {
>> /*
>> * Exported functions
>> */
>> -ICSState *xics_find_source(XICSState *xics, int irq)
>> -{
>> - ICSState *ics;
>> -
>> - QLIST_FOREACH(ics, &xics->ics, list) {
>> - if (ics_valid_irq(ics, irq)) {
>> - return ics;
>> - }
>> - }
>> - return NULL;
>> -}
>> -
>> qemu_irq xics_get_qirq(XICSInterface *xi, int irq)
>> {
>> XICSInterfaceClass *xic = XICS_INTERFACE_GET_CLASS(xi);
>> diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h
>> index 896fa5d87c1c..e10426e98e31 100644
>> --- a/include/hw/ppc/xics.h
>> +++ b/include/hw/ppc/xics.h
>> @@ -222,7 +222,6 @@ void ics_simple_write_xive(ICSState *ics, int nr, int
>> server,
>>
>> void ics_set_irq_type(ICSState *ics, int srcno, bool lsi);
>>
>> -ICSState *xics_find_source(XICSState *icp, int irq);
>> void ics_resend(ICSState *ics);
>>
>> #endif /* XICS_H */
>
