On Wed, Oct 06, 2010 at 09:48:06AM -0600, Alex Williamson wrote:
> > +void qemu_del_vlan_client(VLANClientState *vc)
> > +{
> > + /* If there is a peer NIC, delete and cleanup client, but do not free.
> > */
> > + if (!vc->vlan && vc->peer && vc->peer->info->type ==
> > NET_CLIENT_TYPE_NIC) {
> > + NICState *nic = DO_UPCAST(NICState, nc, vc->peer);
> > + if (nic->peer_deleted) {
> > + return;
> > + }
> > + nic->peer_deleted = true;
> > + /* Let NIC know peer is gone. */
> > + vc->peer->link_down = true;
> > + if (vc->peer->info->link_status_changed) {
> > + vc->peer->info->link_status_changed(vc->peer);
> > + }
> > + if (vc->info->cleanup) {
> > + vc->info->cleanup(vc);
> > + }
>
> This is now the only case that calls cleanup, is that intentional?
> Seems like we won't end up calling nic cleanup routines.
>
> Alex
Good catch.
I'll fix it up, thanks!
