Eric Blake <ebl...@redhat.com> writes: > On 02/21/2017 02:46 PM, Markus Armbruster wrote: >> Simple unions are simpler than flat unions in the schema, but more >> complicated in C and on the QMP wire: there's extra indirection in C >> and extra nesting on the wire, both pointless. They're best avoided >> in new code. Fix up recent commit d187e08 accordingly. >> >> Cc: Anton Nefedov <anton.nefe...@virtuozzo.com> >> Cc: Denis V. Lunev <d...@openvz.org> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> qapi-schema.json | 14 ++++++++++++-- >> target/i386/cpu.c | 17 ++++++----------- >> vl.c | 12 ++++++------ >> 3 files changed, 24 insertions(+), 19 deletions(-) > > Very similar to Anton's patch which is on Paolo's queue: > https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg04448.html
Wasn't cc'ed, so I missed it. No biggie. > I don't care which version goes in, but will leave it to Markus and > Paolo to decide which queue it should go through. My commit message is more verbose, and I fix space style in the QAPI schema. On the other hand, Anton has an extra QAPI schema comment line. Picking Anton's is probably simpler, because it's 2/3, and mine looks like it conflicts with his 1/3. > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks!
