Am 21.02.2017 um 12:54 hat Daniel P. Berrange geschrieben: > When integrating the crypto support with qcow/qcow2, we don't > want to use the bare LUKS option names "hash-alg", "key-secret", > etc. We want to namespace them "luks-hash-alg", "luks-key-secret" > so that they don't clash with any general qcow options at a later > date.
Or maybe "luks.key-secret", i.e. actually embed the LUKS options QAPI type into the qcow2 one? In that case, maybe qdict_extract_subqdict() can even be used before calling into this, so that we don't have to write a QemuOpts version of the function. However, the only option I can see at the end of this series in BlockdevOptionsQcow2 is luks-key-secret, so what happened with this plan? And if we really have only luks-key-secret (and that not in a separate sub-dict), I don't really see the need to have separate aes-key-secret and luks-key-secret options. > Reviewed-by: Max Reitz <mre...@redhat.com> > Reviewed-by: Alberto Garcia <be...@igalia.com> > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> Having said all that, while I'm not sure if the goal of the patch is completely right, it does seem to correctly implement what it promises. Kevin
