On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote:
Adds routine to compute ca32 - gen_op_arith_compute_ca32For 64-bit mode use the compute ca32 routine. While for 32-bit mode, CA and CA32 will have same value. Signed-off-by: Nikunj A Dadhania <nik...@linux.vnet.ibm.com> --- target/ppc/translate.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 498b095..2a2d071 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -816,6 +816,36 @@ static inline void gen_op_arith_compute_ov(DisasContext *ctx, TCGv arg0, tcg_gen_or_tl(cpu_so, cpu_so, cpu_ov); } +static inline void gen_op_arith_compute_ca32(DisasContext *ctx, TCGv arg0, + TCGv arg1, bool add_ca, int sub) +{ + TCGv t0 = tcg_temp_new(); + TCGv t1 = tcg_temp_new(); + TCGv inv0 = tcg_temp_new(); + + tcg_gen_extract_tl(t0, arg0, 0, 32); + tcg_gen_extract_tl(t1, arg1, 0, 32); + if (sub) { + tcg_gen_not_tl(inv0, t0); + if (add_ca) { + tcg_gen_add_tl(t1, t1, cpu_ca32); + } else { + tcg_gen_addi_tl(t1, t1, 1); + } + tcg_gen_add_tl(t0, t1, inv0); + tcg_gen_extract_tl(cpu_ca32, t0, 32, 1); + } else { + tcg_gen_add_tl(t0, t0, t1); + if (add_ca) { + tcg_gen_add_tl(t0, t0, cpu_ca32); + } + tcg_gen_extract_tl(cpu_ca32, t0, 32, 1); + } + tcg_temp_free(t0); + tcg_temp_free(t1); +}
This is incorrect, since you're not considering the carry-in bits. It's also inefficient since you should only need a single extraction.
Compute ca32 via t0 = result ^ in0 ^ in1 extract_tl(ca32, t0, 32, 1) r~
