Re: [Qemu-devel] [PATCH v9 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

[Paolo Bonzini]

On 20/02/2017 11:07, Daniel P. Berrange wrote:
>> +        if (qemu_uuid_is_null(&qemu_uuid)) {
> This is the wrong check - QEMU provides a 'qemu_uuid_set' boolean
> to determine if 'qemu_uuid' is set or not. If it is not set, then
> the code should return an error, not use a hardcoded uuid.

Or otherwise that hardcoded uuid should be all zeroes (UUID_NONE).

Paolo

>> +            if (iio_init(QNIO_VERSION, vxhs_iio_callback, VXHS_UUID_DEF)) {
>> +                return -ENODEV;
>> +            }