On 16 February 2017 at 11:28, Vijay Kilari <vijay.kil...@gmail.com> wrote: > On Thu, Feb 16, 2017 at 3:39 PM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> On 16 February 2017 at 09:54, Vijay Kilari <vijay.kil...@gmail.com> wrote: >>> On Tue, Feb 7, 2017 at 8:19 PM, Peter Maydell <peter.mayd...@linaro.org> >>> wrote: >>>> If you want to do nothing in a read/write function there are >>>> already arm_cp_read_zero and arm_cp_write_ignore functions for >>>> this. But using the ARM_CP_NOP flag is better still. >>> >>> With ARM_CP_NOP qemu fails to boot. >>> qemu-system-aarch64: KVM_SET_DEVICE_ATTR failed: Invalid argument >>> Group 6 attr 0x000000000000c665 >> >> Not clear to me why using ARM_CP_NOP should result in a KVM >> call failure -- can you dig further into why that is happening? > > if ARM_CP_NOP is set, .reset function is not called and there by KVM fails > when SRE_EL1 is written with 0x0.
OK. Use the arm_cp_read_zero/arm_cp_write_ignore functions, and add a comment that we don't use CP_NOP because that means our reset function isn't called. thanks -- PMM
