On 02/08/2017 10:04 AM, Markus Armbruster wrote: > Simple unions are simpler than flat unions in the schema, but more > complicated in C and on the QMP wire: there's extra indirection in C > and extra nesting on the wire, both pointless. They're best avoided > in new code. > > NumaOptions isn't new, but it's only used internally, not in QMP. > Convert it to a flat union. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > numa.c | 4 ++-- > qapi-schema.json | 8 ++++++++ > 2 files changed, 10 insertions(+), 2 deletions(-) >
> +++ b/qapi-schema.json > @@ -5545,6 +5545,12 @@ > 'events' : [ 'InputEvent' ] } } > > ## > +# @NumaOptionsType: > +## Do we want a 'Since: 2.1' designation (since the enum has effectively existed, even if implicitly, for as long as NumaOptions has been around)? With or without that extra line, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
