On Do, 2017-02-02 at 16:20 +0100, Andrea Bolognani wrote: > On Thu, 2017-02-02 at 16:42 +0200, Marcel Apfelbaum wrote: > [...] > > > +[device "ich9-pcie-port-1"] > > > > I would use the new generic root port. > > This sample configuration (q35-emulated.cfg) is supposed to > match physical hardware as closely as possible, so we should > stick with ioh3420s.
Agree. > [...] > > > +[device "pci.1"] > > > + driver = "ioh3420" > > > > Same here, maybe we can use the new generic port. > > These sample configuration files (q35-virtio-*.cfg) should > probably use the generic ports instead, yes. It's just that > they were not merged yet when I started working on this :) Agree too. > > I am not sure about having the DMI-PCI bridge "by default". > > Users can understand is actually a good idea to have it by default > > while we don't really want them to use legacy PCI devices on Q35; > > and even if so, they should use them as Integrated Endpoints. > > They don't have hotplug for the DMI-PCI bridge anyway. > > Not sure about this one. It doesn't show up on my laptop, > so it's not like every single q35-based physical machine has > it. Is your laptop really q35+ich9 or something newer? > I'd be okay with dropping it, but I leave the decision > to Gerd. Please leave it in for qemu-emulated.cfg, as this is supposed to serve as documentation how real q35 hardware looks like. From the virtio variants it can be dropped. > > I personally don't use them because every time I try, I > > find something with no config support.... > > Is that so? Can you please test these new ones and see > whether they work for you? I think mst means that not all qemu command line switches are using QemuOpts, and the ones which don't can't be used with -readconfig. cheers, Gerd
