On 02/02/2017 02:10 PM, Stefan Weil wrote: > Am 02.02.2017 um 21:00 schrieb Eric Blake: >> On 02/02/2017 01:56 PM, Stefan Weil wrote: >>> tb_jmp_insn_offset and tb_jmp_reset_offset are pointers >>> and cannot be used with ARRAY_SIZE. >>>
>> mst posted an alternative patch: >> https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg00551.html > > > Yes, I noticed that, too. It's not obvious that this new > assertion will be correct, and none of the other targets > has that kind of assertion. Only two targets use an > assertion which detects NULL pointers, but NULL pointers > will result in an abort anyway. > > Do you think that there are reasons why TCI should use > the assertion suggested by Michael? I don't have any strong opinions on which patch is better, so much as just pointing out that alternative proposals exist so that we have good threading in making the decision on which one to go with. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
