On 31 January 2017 at 19:37, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Hi > > On Tue, Jan 31, 2017 at 11:00 PM Eric Blake <ebl...@redhat.com> wrote: >> >> On 01/31/2017 12:55 PM, Marc-André Lureau wrote: >> >> >> 'make check' fails on a linux-user-targets-only build: >> >> >> >> tests/test-char.o: In function `char_stdio_test_subprocess': >> >> /home/petmay01/linaro/qemu-for-merges/tests/test-char.c:47: undefined >> >> reference to `qemu_chr_new' >> >> /home/petmay01/linaro/qemu-for-merges/tests/test-char.c:50: undefined >> >> reference to `qemu_chr_fe_init' >> >> /home/petmay01/linaro/qemu-for-merges/tests/test-char.c:51: undefined >> >> reference to `qemu_chr_fe_set_open' >> >> /home/petmay01/linaro/qemu-for-merges/tests/test-char.c:52: undefined >> >> reference to `qemu_chr_fe_write' >> >> [etc etc etc] >> >> >> >> >> > Oh good catch. We want to have chardev-obj-y defined globally, but only >> > linked with -softmmu target. >> > >> > A possible fix to squash with chardev-obj-j patch is: >> > >> > Eric, do you want me to resend the patch for review or is that enough >> > for >> > you to ack? >> > >> >> I'm okay ack'ing the interdiff (that is, squash this in, and you can >> keep the R-b you already have). >> > > Thanks, patch updated, tag updated. > > Peter, let me know if you want me to resend the pull request.
Now applied, thanks. -- PMM
