Am 23.09.2010 22:33, schrieb Blue Swirl:
On Thu, Sep 23, 2010 at 7:28 PM, Stefan Weil <w...@mail.berlios.de> wrote:
Replace the remaining format attribute printf by macro
GCC_FMT_ATTR which uses gnu_printf (if supported).
This needs additional code changes:
* Add qemu-common.h (which defined GCC_FMT_ATTR) were needed.
* Remove standard includes when qemu-common.h was added.
qemu-common.h already provides these includes.
* Remove local definitions which now come from stdio.h.
These definitions were needed before tcg was introduced.
They raise conflicts when qemu-common.h is included.
IIRC the problem was that some system headers were incompatible with
global asm variables. There is still one, AREG0.
But I'd rather not keep the hideous local definitions forever. Maybe
those systems which are broken by the patch are not interesting
anymore?
Are there such systems? Or did the problems with earlier
versions arise from the fact that a lot of global asm variables
were reserved by qemu? How could a correctly defined AREG0
interfere with system headers?
For linux and win32, I did not notice problems caused by these changes.
