On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: > Do not reload bitmap list every time it is needed. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > block/qcow2-bitmap.c | 125 > ++++++++++++++++++++++++++++++++++----------------- > block/qcow2.c | 2 + > block/qcow2.h | 4 ++ > 3 files changed, 89 insertions(+), 42 deletions(-)
Hm, difficult. On a glance, this patch seems alright, and it probably makes sense. Maybe it would make the code actually a bit easier to understand if it was squashed into the other patches. But OTOH it would mean that I would have to start review from scratch for those patches... So in my opinion this patch makes sense and you should keep it updated, but I think we should keep it separate from the rest of the series. Get the first 23 patches in first and then we can merge this on top later on. Would that be OK? Max
signature.asc
Description: OpenPGP digital signature