On 01/30/2017 10:34 AM, Alberto Garcia wrote: > > I don't think QEMU produces files where refcount_table[i] == 0 but > refcount_table[i + 1] != 0. Do they even make sense?
I don't know if qemu can be directly coerced to create such an image, but a third party tool can (and that probably includes qemu-io), and such an image makes sense. In particular, a refcount can be changed from non-zero to zero during garbage collection when all clusters covered by that refcount are no longer in use (perhaps because a snapshot was deleted). > In any case, my > patch would cover those cases too, but this simplified version wouldn't. Since an image can have holes in the refcount_table, it sounds like the simplified version is not robust enough. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
